OCPBUGS-112283: Allow KubeDaemonSetMisScheduled alert on external platform clusters - #31556
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. WalkthroughThe Prometheus alert-state test now detects External platform clusters and allows transient ChangesExternal platform alert handling
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized test-related change has no actionable merge-blocking risk remaining beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 13 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (13 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…m clusters Platform-external clusters experience the same transient DaemonSet mis-scheduling as managed-service clusters: out-of-tree cloud providers taint/label nodes after some platform DaemonSets are initially scheduled, causing KubeDaemonSetMisScheduled to fire briefly until the DaemonSets are rebalanced. Extend the existing managed-service exclusion (OCPBUGS-46079) to also allow this alert on clusters whose infrastructure platform type is External. Introduce a reusable exutil.IsExternalPlatformCluster helper in test/extended/util/framework.go, following the same pattern as IsSelfManagedHA and IsSingleNode, and use it from the Prometheus alerts test instead of an inline Infrastructure lookup. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
efd2580 to
f3a13f8
Compare
|
/payload-job periodic-ci-openshift-release-main-nightly-5.1-opct-platform-external-aws |
|
@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7371e240-a005-11f1-8b50-42097efbf442-0 |
|
Scheduling required tests: |
|
/assign @mtulio |
|
/retitle OCPBUGS-112283: Allow KubeDaemonSetMisScheduled alert on external platform clusters |
|
@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-112283, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-release-main-nightly-5.1-opct-platform-external-aws |
|
/test ? |
|
@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4c5c9c90-a07d-11f1-8af8-09e4861bd61d-0 |
|
@mtulio: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hey @neisw , thanks for handling it. I just see that you already triggered the payload-job. (ignore my last payload-job comment) I see all /verified by CI job - payload job #31556 (comment) I think we can override the failure as those will be unrelated. |
|
@mtulio: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@mtulio: This pull request references Jira Issue OCPBUGS-112283, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@mtulio: This pull request references Jira Issue OCPBUGS-112283, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@mtulio: This pull request references Jira Issue OCPBUGS-112283, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial, ci/prow/e2e-metal-ipi-ovn-ipv6 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtulio, neisw, redhat-chai-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@redhat-chai-bot: Jira Issue Verification Checks: Jira Issue OCPBUGS-112283 Jira Issue OCPBUGS-112283 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-5.0 |
|
@mtulio: #31556 failed to apply on top of branch "release-5.0": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
Extends the
KubeDaemonSetMisScheduledalert exclusion in the Prometheus alerts test to also cover platform-external environments, not just managed-service clusters.Details
The
KubeDaemonSetMisScheduledalert fires transiently on platform-external clusters (e.g. OPCT conformance workflows) for the same reason it fires on managed-service clusters: node taints are applied after platform DaemonSets are already scheduled, causing the alert to fire briefly before rebalancing occurs.The original exclusion (added in OCPBUGS-46079 / PR #29366) was gated on
IsManagedServiceCluster(), which returns false for platform-external environments. This PR extends the condition to also check if the cluster's infrastructure platform type isExternal(configv1.ExternalPlatformType) via the Infrastructure API.Changes
if isManagedService || isExternalPlatformAI-generated. Review for accuracy.
@neisw requested via Chai Bot
Summary by CodeRabbit
KubeDaemonSetMisScheduledalert is now accepted for both managed-service and External clusters.