Skip to content

OCPBUGS-112283: Allow KubeDaemonSetMisScheduled alert on external platform clusters - #31556

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:fix/ocpbugs-112283-kube-daemonset-misscheduled-external-platform
Aug 25, 2026
Merged

OCPBUGS-112283: Allow KubeDaemonSetMisScheduled alert on external platform clusters#31556
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:fix/ocpbugs-112283-kube-daemonset-misscheduled-external-platform

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Extends the KubeDaemonSetMisScheduled alert exclusion in the Prometheus alerts test to also cover platform-external environments, not just managed-service clusters.

Details

The KubeDaemonSetMisScheduled alert fires transiently on platform-external clusters (e.g. OPCT conformance workflows) for the same reason it fires on managed-service clusters: node taints are applied after platform DaemonSets are already scheduled, causing the alert to fire briefly before rebalancing occurs.

The original exclusion (added in OCPBUGS-46079 / PR #29366) was gated on IsManagedServiceCluster(), which returns false for platform-external environments. This PR extends the condition to also check if the cluster's infrastructure platform type is External (configv1.ExternalPlatformType) via the Infrastructure API.

Changes

  • Added Infrastructure API lookup to detect external platform type
  • Combined managed-service and external-platform checks: if isManagedService || isExternalPlatform
  • Added comment referencing OCPBUGS-112283 explaining the platform-external case

AI-generated. Review for accuracy.

@neisw requested via Chai Bot

Summary by CodeRabbit

  • Tests
    • Updated Prometheus alert-state validation to support clusters using the External platform type.
    • The KubeDaemonSetMisScheduled alert is now accepted for both managed-service and External clusters.
    • Improved cluster platform detection during extended test execution, ensuring alert checks accurately reflect the infrastructure configuration and reducing false test failures for supported External platform environments.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Aug 24, 2026
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 89a3f9eb-0e8e-4b4e-9254-9ed6efa6f0eb

📥 Commits

Reviewing files that changed from the base of the PR and between efd2580 and f3a13f8.

📒 Files selected for processing (2)
  • test/extended/prometheus/prometheus.go
  • test/extended/util/framework.go

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


Walkthrough

The Prometheus alert-state test now detects External platform clusters and allows transient KubeDaemonSetMisScheduled alerts for External or managed service clusters.

Changes

External platform alert handling

Layer / File(s) Summary
Platform detection and alert validation
test/extended/util/framework.go, test/extended/prometheus/prometheus.go
The framework retrieves the cluster Infrastructure object and checks for configv1.ExternalPlatformType. The Prometheus test uses this result with managed-service status when it allows the transient alert.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to f3a13

This localized test-related change has no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: slashpai, rexagod

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Test Structure And Quality ⚠️ Warning The new cluster API error assertion uses o.Expect(err).NotTo(o.HaveOccurred()) without a diagnostic message, matching the check's explicit failure example. Add a meaningful message, such as failed to get cluster infrastructure while detecting External platform, to the new assertion.
✅ Passed checks (13 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the bug and the main change: allowing the alert on external platform clusters.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The HEAD diff adds only alert logic, a comment, and a helper. Ginkgo It/Describe titles are identical in HEAD^ and HEAD, with no added dynamic title values.
Microshift Test Compatibility ✅ Passed The PR modifies an existing test, not a new Ginkgo test. The changed test has [apigroup:config.openshift.io], so MicroShift CI skips it because the referenced API group is unavailable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The diff adds no Ginkgo test and introduces no multi-node or HA assumption; it only changes alert allowances and adds an Infrastructure API helper, which is supported on SNO.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only changes an extended Prometheus test and adds an Infrastructure API read helper; it adds no manifests, controllers, operators, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The diff adds only an Infrastructure GET and alert condition inside a Ginkgo It block; no main/init/suite-setup stdout write or logging configuration change was introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff modifies an existing alert test and adds only a cluster Infrastructure API lookup; no IPv4 literals, IPv4-only parsing, or external/public connectivity was introduced.
No-Weak-Crypto ✅ Passed The exact patch only adds infrastructure platform detection and alert-test logic; it introduces no weak-crypto primitive, custom crypto, or secret/token comparison.
Container-Privileges ✅ Passed The diff changes only two Go source files. Added lines contain no privileged:true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR diff adds no logging or output calls and no sensitive values; it only reads Infrastructure.Status.PlatformStatus.Type and changes alert allowlisting.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from rexagod and slashpai August 24, 2026 20:45
…m clusters

Platform-external clusters experience the same transient DaemonSet
mis-scheduling as managed-service clusters: out-of-tree cloud providers
taint/label nodes after some platform DaemonSets are initially scheduled,
causing KubeDaemonSetMisScheduled to fire briefly until the DaemonSets are
rebalanced. Extend the existing managed-service exclusion (OCPBUGS-46079)
to also allow this alert on clusters whose infrastructure platform type is
External.

Introduce a reusable exutil.IsExternalPlatformCluster helper in
test/extended/util/framework.go, following the same pattern as
IsSelfManagedHA and IsSingleNode, and use it from the Prometheus alerts
test instead of an inline Infrastructure lookup.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@redhat-chai-bot
redhat-chai-bot force-pushed the fix/ocpbugs-112283-kube-daemonset-misscheduled-external-platform branch from efd2580 to f3a13f8 Compare August 24, 2026 21:32
@neisw

neisw commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

/payload-job periodic-ci-openshift-release-main-nightly-5.1-opct-platform-external-aws

@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-5.1-opct-platform-external-aws

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7371e240-a005-11f1-8b50-42097efbf442-0

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@neisw

neisw commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/assign @mtulio

@mtulio

mtulio commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/retitle OCPBUGS-112283: Allow KubeDaemonSetMisScheduled alert on external platform clusters

@openshift-ci openshift-ci Bot changed the title Bug 112283: Allow KubeDaemonSetMisScheduled alert on external platform clusters OCPBUGS-112283: Allow KubeDaemonSetMisScheduled alert on external platform clusters Aug 25, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 25, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-112283, which is invalid:

  • expected the bug to target the "5.1.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Extends the KubeDaemonSetMisScheduled alert exclusion in the Prometheus alerts test to also cover platform-external environments, not just managed-service clusters.

Details

The KubeDaemonSetMisScheduled alert fires transiently on platform-external clusters (e.g. OPCT conformance workflows) for the same reason it fires on managed-service clusters: node taints are applied after platform DaemonSets are already scheduled, causing the alert to fire briefly before rebalancing occurs.

The original exclusion (added in OCPBUGS-46079 / PR #29366) was gated on IsManagedServiceCluster(), which returns false for platform-external environments. This PR extends the condition to also check if the cluster's infrastructure platform type is External (configv1.ExternalPlatformType) via the Infrastructure API.

Changes

  • Added Infrastructure API lookup to detect external platform type
  • Combined managed-service and external-platform checks: if isManagedService || isExternalPlatform
  • Added comment referencing OCPBUGS-112283 explaining the platform-external case

AI-generated. Review for accuracy.

@neisw requested via Chai Bot

Summary by CodeRabbit

  • Tests
  • Updated Prometheus alert-state validation to support clusters using the External platform type.
  • The KubeDaemonSetMisScheduled alert is now accepted for both managed-service and External clusters.
  • Improved cluster platform detection during extended test execution, ensuring alert checks accurately reflect the infrastructure configuration and reducing false test failures for supported External platform environments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio

mtulio commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/payload-job periodic-ci-openshift-release-main-nightly-5.1-opct-platform-external-aws

@mtulio

mtulio commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/test ?

@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-5.1-opct-platform-external-aws

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4c5c9c90-a07d-11f1-8af8-09e4861bd61d-0

@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@mtulio: The following commands are available to trigger required jobs:

/test agentic-images
/test e2e-aws-csi
/test e2e-aws-jenkins
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-image-registry
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-builds
/test e2e-gcp-ovn-image-ecosystem
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi
/test go-verify-deps
/test images
/test lint
/test okd-scos-images
/test unit
/test verify
/test verify-deps
/test verify-image-manifest-lists

The following commands are available to trigger optional jobs:

/test e2e-agent-compact-ipv4-iso-no-registry
/test e2e-agnostic-ovn-cmd
/test e2e-aws-disruptive
/test e2e-aws-etcd-certrotation
/test e2e-aws-etcd-recovery
/test e2e-aws-ovn
/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-dra-example
/test e2e-aws-ovn-edge-zones
/test e2e-aws-ovn-etcd-scaling
/test e2e-aws-ovn-kube-apiserver-rollout
/test e2e-aws-ovn-kubevirt
/test e2e-aws-ovn-serial-fast
/test e2e-aws-ovn-serial-ipsec
/test e2e-aws-ovn-serial-publicnet-1of2
/test e2e-aws-ovn-serial-publicnet-2of2
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-single-node-serial
/test e2e-aws-ovn-single-node-techpreview
/test e2e-aws-ovn-single-node-techpreview-serial
/test e2e-aws-ovn-single-node-upgrade
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-upgrade-rollback
/test e2e-aws-ovn-upi
/test e2e-aws-proxy
/test e2e-aws-tls-observed-config
/test e2e-aws-tls-observed-config-fips
/test e2e-aws-tls-observed-config-hypershift
/test e2e-azure
/test e2e-azure-ovn-etcd-scaling
/test e2e-azure-ovn-upgrade
/test e2e-baremetalds-kubevirt
/test e2e-external-aws
/test e2e-external-aws-ccm
/test e2e-external-vsphere-ccm
/test e2e-gcp-disruptive
/test e2e-gcp-fips-serial-1of2
/test e2e-gcp-fips-serial-2of2
/test e2e-gcp-ovn-etcd-scaling
/test e2e-gcp-ovn-kube-apiserver-rollout
/test e2e-gcp-ovn-rt-upgrade
/test e2e-gcp-ovn-techpreview
/test e2e-gcp-ovn-techpreview-pkiconfig
/test e2e-gcp-ovn-techpreview-serial-1of2
/test e2e-gcp-ovn-techpreview-serial-2of2
/test e2e-gcp-ovn-usernamespace
/test e2e-hypershift-conformance
/test e2e-metal-ipi-ovn
/test e2e-metal-ipi-ovn-bgp-virt-dualstack
/test e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-dualstack-bgp
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
/test e2e-metal-ipi-ovn-dualstack-local-gateway
/test e2e-metal-ipi-ovn-kube-apiserver-rollout
/test e2e-metal-ipi-serial-1of2
/test e2e-metal-ipi-serial-2of2
/test e2e-metal-ipi-serial-ovn-ipv6-1of2
/test e2e-metal-ipi-serial-ovn-ipv6-2of2
/test e2e-metal-ipi-virtualmedia
/test e2e-metal-ovn-single-node-live-iso
/test e2e-metal-ovn-single-node-with-worker-live-iso
/test e2e-metal-ovn-two-node-arbiter
/test e2e-metal-ovn-two-node-fencing
/test e2e-metal-ovn-two-node-fencing-recovery
/test e2e-openstack-dualstack-v6primary
/test e2e-openstack-ovn
/test e2e-openstack-serial
/test e2e-vsphere-ovn-etcd-scaling
/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-main-agentic-images
pull-ci-openshift-origin-main-go-verify-deps
pull-ci-openshift-origin-main-images
pull-ci-openshift-origin-main-lint
pull-ci-openshift-origin-main-okd-scos-images
pull-ci-openshift-origin-main-unit
pull-ci-openshift-origin-main-verify
pull-ci-openshift-origin-main-verify-deps
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mtulio

mtulio commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

hey @neisw , thanks for handling it. I just see that you already triggered the payload-job. (ignore my last payload-job comment)

I see all [sig-instrumentation] Prometheus passing in the job results.

/verified by CI job - payload job #31556 (comment)
/lgtm
/approve

I think we can override the failure as those will be unrelated.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 25, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@mtulio: This PR has been marked as verified by CI job - payload job https://github.com/openshift/origin/pull/31556#issuecomment-5401808765.

Details

In response to this:

hey @neisw , thanks for handling it. I just see that you already triggered the payload-job.

I see they all passing in the job.

/verified by CI job - payload job #31556 (comment)
/lgtm
/approve

I think we can override the failure as those will be unrelated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2026
@mtulio

mtulio commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@mtulio: This pull request references Jira Issue OCPBUGS-112283, which is invalid:

  • expected the bug to target the "5.1.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio

mtulio commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@mtulio: This pull request references Jira Issue OCPBUGS-112283, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio

mtulio commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 25, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@mtulio: This pull request references Jira Issue OCPBUGS-112283, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@neisw

neisw commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/approve
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-aws-ovn-microshift

@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial, ci/prow/e2e-metal-ipi-ovn-ipv6

Details

In response to this:

/approve
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-aws-ovn-microshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtulio, neisw, redhat-chai-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 3068afd into openshift:main Aug 25, 2026
22 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@redhat-chai-bot: Jira Issue Verification Checks: Jira Issue OCPBUGS-112283
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-112283 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

Extends the KubeDaemonSetMisScheduled alert exclusion in the Prometheus alerts test to also cover platform-external environments, not just managed-service clusters.

Details

The KubeDaemonSetMisScheduled alert fires transiently on platform-external clusters (e.g. OPCT conformance workflows) for the same reason it fires on managed-service clusters: node taints are applied after platform DaemonSets are already scheduled, causing the alert to fire briefly before rebalancing occurs.

The original exclusion (added in OCPBUGS-46079 / PR #29366) was gated on IsManagedServiceCluster(), which returns false for platform-external environments. This PR extends the condition to also check if the cluster's infrastructure platform type is External (configv1.ExternalPlatformType) via the Infrastructure API.

Changes

  • Added Infrastructure API lookup to detect external platform type
  • Combined managed-service and external-platform checks: if isManagedService || isExternalPlatform
  • Added comment referencing OCPBUGS-112283 explaining the platform-external case

AI-generated. Review for accuracy.

@neisw requested via Chai Bot

Summary by CodeRabbit

  • Tests
  • Updated Prometheus alert-state validation to support clusters using the External platform type.
  • The KubeDaemonSetMisScheduled alert is now accepted for both managed-service and External clusters.
  • Improved cluster platform detection during extended test execution, ensuring alert checks accurately reflect the infrastructure configuration and reducing false test failures for supported External platform environments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio

mtulio commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/cherry-pick release-5.0

@openshift-cherrypick-robot

Copy link
Copy Markdown

@mtulio: #31556 failed to apply on top of branch "release-5.0":

Applying: Bug 112283: Allow KubeDaemonSetMisScheduled alert on external platform clusters
Using index info to reconstruct a base tree...
M	test/extended/prometheus/prometheus.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/prometheus/prometheus.go
CONFLICT (content): Merge conflict in test/extended/prometheus/prometheus.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Bug 112283: Allow KubeDaemonSetMisScheduled alert on external platform clusters

Details

In response to this:

/cherry-pick release-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants